3096 / genshin_scripts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Script won't play any key/note more than once

m4xolotl opened this issue · comments

it won't play any note after it has already been played previously
So a sequence of CDCFGAB CDEFGAB becomes CD_FGAB _ E _ _ _

it took me hours to realise what was the problem, i initially thought the script wasn't playing anything beyond the first bar (because my initial test midi was just 2 bars of CDEFGAB), but then realised the real problem after randomly testing CDCFGAB CDEFGAB

This is the output when outputting to notepad; assaaffgghhjjqq aassddffgghhjjqq

2 issues here; Every note after the 1st seems to be duplicated. Also the second C is (surprisingly) showing up in the output as the "aa" after the "ss", but it isn't playing in actual Genshin...

strange

commented

Yeah when the key is already pressed and there's an overlap, the current setup doesn't actually press it again. I'll look into this.
The game also needs a delay to register keypresses I think.
One way around this could be simply making every press a "quick tap". But off the top of my head, it would need a different loop structure...

commented

aight I pushed a change that adds a config to only briefly click each note. does it solve the missing notes issue?