2mol / pboy

a small .pdf management tool with a command-line UI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Viewer launch is blocking

n-st opened this issue · comments

Currently, paperboy waits for the external viewer command to exit before returning:

pboy/src/Lib.hs

Line 187 in 6f4dff9

E.try (P.readProcess cmd [Path.fromAbsFile file] "")

It would be useful to be able to view multiple files in parallel.

(This could be done by changing XDG file associations and registering a forking program as the default viewer, but hopefully this can be solved more cleanly in paperboy itself.)

commented

Thanks for noticing this, I didn't know it was blocking. Maybe on mac it's different than on linux, I'll test.

If you have a Haskell environment installed, then it would be cool if you could try to change the line you highlighted and send me a PR. It doesn't need to be perfect, we'll merge it into dev and continue working from there. If you have questions about how to do any of the above, I'm here to explain stuff!

commented

merged PR, will release in 1.3