Publish on Bower
FluorescentHallucinogen opened this issue · comments
Please create bower.json file and publish this package in Bower registry .
Can you explain how we add the package to bower without built files in the repository?
Why not add built files into the repo? It's not an anti-pattern anymore.
2gis-maps-react package now available on Bower. But looks like it requires 2gis-maps package. But 2gis-maps is not available on Bower. That's why I've opened this issue.
I'm not sure 2gis-maps-react really requires 2gis-maps, because package.json of 2gis-maps-react doesn't contain "2gis-maps" in "dependencies", but README.md of 2gis-maps-react suggests use npm install 2gis-maps-react 2gis-maps command for installation instead of just npm install 2gis-maps-react. See 2gis/2gis-maps-react#7.
BTW, since you use Git tags, if you'll add built files into the repo, you can serve them directly from GitHub with proper Content-Type header using RawGit (https://rawgit.com), a free service based on MaxCDN's (https://maxcdn.com) super fast global CDN. 😉
And please don't forget to update GitHub releases.
We will not add build files because it creates many merge conflicts and makes code review more difficult.
I think we can look into how https://github.com/Leaflet/Leaflet doing this without built files in the repo.
Any progress?
Sorry I am a little bit busy right now, but you can create your own pull request
Should all packages from "dependencies" and "devDependencies" be published on Bower?