A condition based on an english hardcoded string cause CMLoot to fail on non english systems

Question

Z4kSec opened this issue 2 years ago · comments

First, thanks a lot for this awesome tool.

While using it, I had a specific usecase where the SCCMContentLib share was configured as hidden (SCCMContentLib$).

This share can still be accessed by my domain user, but it will not be displayed by the net view commands (line 61).

I didn't create any pull request cause I don't know how you want to manage this case. But it could be nice to implement it natively ! :)

Zak · Answer 1 · Thu Dec 08 2022 00:37:52 GMT+0800 (China Standard Time)

My bad, the /all net view option displays the hidden share. But I think the issue is due to the -match conditions (line 65.

Indeed, SCCMContentLib$ doesn't match SCCMContentLib. Maybe replacing this line by if ($share -like 'SCCMContentLib*') { could do the job ;)

Tomas Rzepka · Answer 2 · Thu Dec 08 2022 00:46:48 GMT+0800 (China Standard Time)

Great find, thx! I'll try to push a fix in a few days. I'm also replacing Get-ChildItem as it is very slow. :)

Zak · Answer 3 · Thu Dec 08 2022 01:08:14 GMT+0800 (China Standard Time)

Okay so the root cause was not due to my latest explainations... You can ignore them x)

Indeed, the langage of the system is not in english so the hardcoded string " Disk " line 62 doesn't match to the net view output.

Sorry for all of these messages ! :)