TERRIBLE variable names in this project
1j01 opened this issue · comments
Isaiah Odhner commented
Inconsistent styling, and unpleasant to work with because I can't tell what things are just by looking at them
For instance I got tripped up by the difference between str
and s
, which are both abbreviations of the word "string", but one of which is a GuitarString
and one of which is a number (an index into the array of guitar strings). Neither are strings, which is funny, but, ay-ai-ai, not good, not good stuff
Isaiah Odhner commented
Also I should move the source files to a folder, and set up auto formatting
and update dependencies