1e0ng / simhash

A Python Implementation of Simhash Algorithm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Usage of `collections.Iterable` which is absent in Python 3.10

dluciv opened this issue · comments

Hello, thank you for your beautiful library!

In Python 3.9+ (corrected: 3.10!) collections module does not contain Iterable. It is deprecated since Python 3.3, and collections.abc.Iterable is suggested to be used instead.

It is used in the code though:

elif isinstance(value, collections.Iterable):
, which causes a crash.

commented

Hi, by Python 3.9+ do you mean 3.10?

I can see the CI passes for Python 3.9 here: https://github.com/1e0ng/simhash/runs/4549604030?check_suite_focus=true#step:5:9

Hello!

I tested on 3.10, but before, on 3.8, using collections.Iterable caused deprecation warning on removing it since 3.9. If it still works in 3.9, then sorry, 3.10+ =).

Than you!