Secret injector deployment incorrectly marked as hook
alexnederlof opened this issue · comments
Alex Nederlof commented
Your environment
Chart Version: latest
Helm Version: latest
Kubernetes Version: 1.26
What happened?
The helm deploy is stuck, because the deployment is marked as a hook here: https://github.com/1Password/connect-helm-charts/blob/main/charts/secrets-injector/templates/deployment.yaml#L10
But since the hook never completes (because it's a deployment), the deploy never completes and helm gets stuck.
Removing the hook annotation fixes it.
What did you expect to happen?
The helm chart to work
Steps to reproduce
Try deploying the helm chart. I did it through Argo. It times out on waiting for the hook to complete.