1904labs / dom-to-image-more

Generates an image from a DOM node using HTML5 canvas

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The regular expression matching in the urlAsRegex() function seems different from the old version, is bug ?

jimhug034 opened this issue · comments

commented

Use case: description, code

3.x version:

 function urlAsRegex(urlValue) {
    return new RegExp(`(url\\(['"]?)(${util.escape(urlValue)})(['"]?\\))`, 'g')
}

2.x version

function urlAsRegex(urlValue) {
 return new RegExp(`(url\\([\'"]?)(${util.escape(urlValue)})([\'"]?\\))`, 'g');
 }
  • Chrome 49+
  • Firefox 45+