18F / uswds-jekyll

A Jekyll theme showcasing the U.S. Web Design System

Home Page:https://federalist-proxy.app.cloud.gov/site/18f/uswds-jekyll/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

duplicate `main` elements and IDs

iamjolly opened this issue · comments

Noticed when using the page layout... seems to be only this layout that has this problem.

The page layout specifies a <main ... id="main-content" ... > which is then included inside another <main ... id="main-content" ... > block within the default layout.

Pages should have only one main element/region, and they should have no duplicate IDs.

Suggest changing the <main> to a <div> in the page layout to fix.

@iamjolly, @ryanhofdotgov - Has this been addressed? Can this issue be closed now?

I don't think so? I've really only worked around it in my template, just following what folks did in ux-guide. The uswds-jekyll docs say "[post] is identical to the layout page", which isn't true anymore, and I don't quite understand the context of the original, cascading change:
7e663f0#diff-2c19d9859b055d0302043d0fa2833e3f

In short, I'm not sure if this is a bug or a feature.

Closing as stale, on the assumption that the need will resurface if it still exists.