18F / uswds-jekyll

A Jekyll theme showcasing the U.S. Web Design System

Home Page:https://federalist-proxy.app.cloud.gov/site/18f/uswds-jekyll/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

use grid for layout?

afeld opened this issue · comments

I was surprised to find that while there is usa-grid class on the main-content, USWDS grid classes aren't actually being used for layout of the sidebar/pages. @line47 Is there a specific reason?

That's a good catch, the reason the grid is not being used on the pages with sidebar is because the grid was switching the layout to mobile at breakpoints that were not optimal. Taken from something similar for the side nav of the USWDS site https://designsystem.digital.gov/components/

Today I Learned about CSS calc()!

screen_shot_2018-06-07_at_1_31_42_pm

Anyway, weird that the sidenav "compare" example uses the grid, while the components page itself calc()ulates the width on its own. Curious to hear what the USWDS team recommends.

cc uswds/uswds#1745

This project is in maintenance mode, so closing.