Giters

18F / frontend

18F's Front End Guild –  content has been moved to https://github.com/18F/development-guide

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Guidelines for Work In Progress [WIP] pull requests

juliaelman opened this issue · comments

commented

The guild would like to provide some sort of reference materials or guide for Work In Progress [WIP] pull requests. Here are a few things to help inform what we'd like in the guide:

  • What is a Work In Progress [WIP] pull request?
  • How do we indicate that something is a WIP?
  • Should teammates be reviewing code that is a WIP?
  • How do we avoid scope creep on these types of pull requests?

This may belong in the 18F guide instead, but are starting here for now, refs https://handbook.18f.gov/github/#pull-requests

commented

Quote @rogeruiz found:

use the pull request as the master of record for the work related to a feature.

commented

I believe the quote is pulled from Carlos Perez's Pull Request First post.

commented

This is now documented in the CONTRIBUTING.md section.