Giters

18F / charlie

18F's Slack bot, Charlie. Built on Bolt

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deployment questions from 18F/hubot-slack-github-issues

mbland opened this issue · comments

commented

I've got a few questions from 18F/hubot-slack-github-issues#4, plus one I forgot to mention there:

  • What is the feasibility of deploying a config.json to production without checking it directly into 18F/18f-bot?
    • Should I extract the GitHub token as an env var and check the rest of the config.json into this repo instead?
  • How comfortable would y'all be switching 18F/18f-bot to an 18F fork of hubot-slack to support reaction_added messages before that support is added upstream? (As noted in 18F/hubot-slack-github-issues#4, I'm going to ping slackhq about this, too.)
  • The current Node.js engine in package.json is 0.10.x. Is that what's actually running in production? I'm using features that aren't supported until 4.2. Any chance for an upgrade?

Happy to discuss either in this issue or that one, or to set up a Hangout or something to chat in real-time.

commented

What is the feasibility of deploying a config.json to production without checking it directly into 18F/18f-bot?

See 18F/hubot-slack-github-issues#4 (comment).

Should I extract the GitHub token as an env var and check the rest of the config.json into this repo instead?

Yes please!

How comfortable would y'all be switching 18F/18f-bot to an 18F fork of hubot-slack to support reaction_added messages before that support is added upstream?

As long as we make a note about the reason, 👍

The current Node.js engine in package.json is 0.10.x. Is that what's actually running in production?

Yep – the Node buildpack should respect that.

Any chance for an upgrade?

I think our version of hubot may require 10.x, but that's probably due for an upgrade as well. 👍

commented

Our 18F/hubot-slack-github-issues Hubot plugin is now running successfully as a npm package as of #42 (and #43). Thanks for all the help, @afeld!