Giters

18F / charlie

18F's Slack bot, Charlie. Built on Bolt

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inclusion bot: Don't trigger on emoji

mgwalker opened this issue · comments

commented

The process for approving/renaming/removing emoji is distinct from the Inclusion Bot. If an emoji is approved, users should not be notified for using it.

E.g., :am-i-crazy:

If the emoji should be removed or renamed, that should be taken up elsewhere.

commented

Are you already working on this one? If not I might take a look. Regex wrangling might be a fun puzzle for me today 😄

commented

It's yours! I'm working on updating my personal readme this morning. 😄

commented

👋🏻 I was kind of happy to see that the inclusion bot was flagging an emoji alias's language, since that's also a method of communication in slack as much as a typed message.

Is there some sort of check during the custom emoji process for this? I wonder how this gets flagged / checked in the future if we remove it.

commented

We could have the bot periodically pull a list of all emoji, check them against the Inclusion Bot's word/phrase list, and report that somewhere? We could even do that now to find any problematic emoji names that already exist. For now, when new emoji are created, they go must be manually approved and the approval criteria specifically refers to ensuring that they are in line with our diversity and inclusion values. But I agree this is a good thing to talk about before we implement this.

Ping @adborden: I think you've thought about longer-term solutions for emoji approvals, and it might be possible to loop the Inclusion Bot into that process as a first check on emoji names and stuff at some point.

commented

A preliminary check to aide emoji admins sounds like a good idea. If you feel like you're close to having a working implementation, open an issue in 18F/tts-tech-portfolio so we can integrate it with the process.

commented

Here are the emoji that currently trigger a bot response:

:am-i-crazy:
:derp:
:ninja-moves:
:russ-maniac:
:russ-maniac-2:
:taking-crazy-pills:
  • :am-i-crazy: and :taking-crazy-pills: are both aliases for :samelook:. After discussion with some folks from the neurodiversity channel, we've concluded that both aliases should be removed. I appreciate the intent of this emoji, and would invite a discussion about how we use the word "crazy." Maybe a good topic for #processing-privilege? I'm really at a loss for a better way to express the feeling that this emoji and its name conveys.
  • :derp: is an alias of :doh:. The alias should be removed.
  • :ninja-moves: is an animation of an actual ninja. I think it's probably fine since it's not misusing the term? I would probably vote that we add this one in particular as an exception to the bot.
  • :russ-maniac: and :russ-maniac-2: are both references to a person who is no longer at TTS, and I think it would be safe to deprecate those.
commented

I think we've informally decided not to do this. At this moment, only the standard Unicode 🥷 emoji should trigger the bot, but having the bot continue to check emoji can act as an extra backstop for emoji approval.