18F / charlie

18F's Slack bot, Charlie. Built on Bolt

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Timebot does not support 24 hour time

jduss4 opened this issue · comments

Currently the timebot does not return correct time zone responses if a 24 hour time is passed in. Currently timebot does not accommodate "pm" when 24 hour time is passed in.

Do we want it to support 24 hour time? If so, should it return 12 hour time (+ "pm" if relevant) or return 24 hour time?

Relevant to b15b268

For simplicity, I would suggest that if the user-entered time is >= 13:00, we show the result with am/pm text always. That should do for now?

I believe this is resolved?

image