Remove CircleCI
caleywoods opened this issue · comments
Feature suggestion
The 18F website was recently migrated from Jekyll to 11ty and with that we're now using GitHub actions to validate HTML, check links, and do linting on pull requests instead of CircleCI. I'm proposing that we should remove CircleCI.
I wanted to open this issue for discussion before I just go deleting things.
Work required
From what I can tell, the work is:
- Delete the CircleCI webhook from the repo webhook settings page
- Remove the CircleCI deploy key
- Tell CircleCI we'd like them to stop building the project by clicking "Stop Building" at the bottom of the settings page for the 18f.gsa.gov project on CircleCI
- Remove
.circleci/config.yml
and delete the.circleci
directory
Who is going to do this work?
I'm happy to take this on, it seems like a quick thing to do.
References
I think this makes a lot of sense. Let's just do it. I don't think this needs a lot of discussion -- I don't think anyone else will complain, as long as tests run somewhere and the test results are shown in pull requests/merges/etc.
I think this makes a lot of sense. Let's just do it. I don't think this needs a lot of discussion -- I don't think anyone else will complain, as long as tests run somewhere and the test results are shown in pull requests/merges/etc.
I agree, I was just hoping not to pull the rug out from under someone in case I had overlooked something still being done on CircleCI.