Giters

10up / 10up-toolkit

Official 10up asset building toolkit.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

editor-style.css vs. Scaffold theme editor-style-overrides.css

bjorn2404 opened this issue · comments

commented

10up-toolkit/packages/toolkit/config/postcss.config.js

Line 18 in abc5afb

if (path.basename(file) === 'editor-style.css') {

There appears to be a naming discrepancy with this file name vs. the name of the file in the Scaffold's example theme via this commit: 10up/wp-scaffold@5e044b1

Maybe the file in the theme shouldn't have been renamed? Or, could this be updated to account for both file names?

commented

Hey @bjorn2404 👋

The reason this was renamed was specifically because of this. The treatment here is no longer desirable because when yoz add your stylesheet via the add_editor_styles function, or via the enqueue_block_asset it loads in the editor and gets scoped to the .editor-styles-wrapper already. So there is no need for this plugin anymore (in 95% of cases)

commented

Thanks, got it. I was doing a manual migration to WP Scaffold for a project and it looks like it was using enqueue_block_editor_assets vs. enqueue_block_assets for editor styles, which is why the wrapper class wasn't being added.