100mslive / 100ms-web

A conferencing and streaming UI built with 100ms SDK.

Home Page:https://examples-videoconferencing.app.100ms.live/preview/tmz-qdi-cyp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue while local setup

mani-rsg opened this issue · comments

Describe the bug
While I follow the steps mentioned in the Readme.md to set up the application locally for enhancement, found following issues:

  • In the actual application the code const envPolicyConfig = JSON.parse(process.env.REACT_APP_POLICY_CONFIG || "{}"); . was present as const envPolicyConfig = JSON.parse(process.env.REACT_APP_POLICY_CONFIG || false); which caused an error while parsing, so I was able to see only a blank screen.

  • A closing curly brace was missing in the example of REACT_APP_POLICY_CONFIG REACT_APP_POLICY_CONFIG = "{"trainer":{"center": ["student"],"sidepane":["trainer"]}"

To Reproduce
Steps to reproduce the behavior:

  1. Just follow the steps one by one and try to run the app locally and you'll face this issue.

can you please send a PR with both of these fixed as well? thanks.

Sure

Updated the Readme.md and Rasied PR