07th-mod / umineko-question

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Clothes switching functions cause old sprites to disappear

drojf opened this issue · comments

In the question arcs, clothes switching is done by calling the clothes switch functions which rebind certain variables controling the sprites for each character:

example:

gosub *MAR_Isyou3
gosub *ROS_Isyou2
*ROS_Isyou2
mov $ROS_DefA1,"bmp\TATI\ROS\2\ROS_DefA1"          ;楼座立ち絵デフォ
mov $ROS_WaraiA1,"bmp\TATI\ROS\2\ROS_WaraiA1"          ;笑い
...
mov $ROS_IkariA4,"bmp\TATI\ROS\2\ROS_IkariA4"
mov $ROS_AseruA1,"bmp\TATI\ROS\2\ROS_AseruA1"
return

This works fine with the new sprites because there is a '2' folder inside the 'bmp\tati\ros' folder, but the old sprites do not have such a folder, causing the sprites to dissapear.

The easy solution is to add an if statement in each of the clothes switching functions which doesn't perform the switch if old sprites are enabled. Could also do a fileexist on the first sprite path.

I also tested what happens if you save after a clothes switch, and that appears to work correctly, so that means (probably) the sprite path variables are set as persistent (by being in the persistant variable range of numbers)

EDIT: I believe another way to fix this issue would be to generate upscaled ryukishi sprites and then just overwrite the normal sprites with them. Then we can deal with the missing sprites by just adding duplicate sprites for the alternate clothes.