Question arcs ADV Mode/1080p development
drojf opened this issue · comments
I'm listing the known bugs/gotchas for ADV mode as I work on it here, mainly because they might be hard to fix and might not occur often enough for you to notice them unless you do a full playthrough:
Missing Features (compared to Answer Arcs)
Known bugs
-
It is theoretically possible for the text to overflow the textbox, if there is a very long text line, but I haven't seen this happen yet. Please let me know if you see this happen
-
If the text is cleared (as no more space is left), and the next sentence to be displayed has a space in front of it, the space will be displayed (the first sentence will be indented slightly). I don't know if this can be fixed easily.
-
clicking during a voicedelay command (my custom command) causes the text to stop displaying half way through the sentence, and only fully display once the the text has reached the end. . It may be possible to fix this by making the game 'freeze' in the pretext callback, so that at least the next line is displayed. For now I will just leave it. EDIT: is this fixed now? I haven't seen it happen in a while?
Example
langjp:voicedelay 1600:dwave_jp 0, nan_1e21:^^遣り残し。@:dwave_jp 0, nan_1e22:受け継いで欲しいことや、/
langen:voicedelay 1600:dwave_eng 0, nan_1e21:^�or matters you have left unfinished.^@:dwave_eng 0, nan_1e22:^ Things you want to pass down to others...^/
langjp:voicedelay 1890:dwave_jp 0, nan_1e23:^^……伝えたいこと。@:dwave_jp 0, nan_1e24:……何でもいいんです。」\
langen:voicedelay 1890:dwave_eng 0, nan_1e23:^�...or merely matters you wish to communicate.^@:dwave_eng 0, nan_1e24:^ ......Anything you want."^/
-
end scrolls have wrong timing (affects non-adv mode as well) EDIT: I have gone through all the credits and it should be fixed now, but it's possible I missed some credits. Let me know if you have credits problems.
-
No method to switch to alternate textbox. Also, black textbox has the wrong (answer arcs) icon!
Some other notes which are not bugs:
- you can change the font at runtime using the
pmapfont
command (I thought you couldn't because there is also ah_mapfont
command which you can only use in the definition section of the program - you can use clickwaits in the clickwait callback but it will cause an infinite loop unless you have some way to break out of it. I can't think of a good reason to do this
- you can't print text in a pretext callback, it will cause an infinite loop
TODO:
remove not used ADV functions. I put some functions in earlier which I thought I'd use, but they're not used anymore.once ADV mode is finished, add a notice at the start of the script that ADV mode has been added
Fixed bugs
- fixed: the *text_cw (clickwait callback) and *pretext (callback before each text phrase is displayed) occur for both the japanese and english lines and clickwaits. This caused some wierd bugs, but I have fixed it by using the same method that was originally in the script:
getreadlang %cur_read_lang
if %cur_read_lang != %cur_language jumpf
do stuff here
~
This also renders what I did with the 'dwave_jp' and 'dwave_eng' useless - I only mad ethose functions because I didn't know how to check whether you were in japanese or english mode :S.
-
fixed - it turns out there aren't that many special regions in the script, unless I missed them. The answer arcs had way more - Special text regions aren't supported yet (to be copied from umitweak)
-
fixed: adv mode is cleared when encountering a setwindow command, and not automatically enabled at game startup: this one is relatively easy to fix, but hasn't been done yet.
-
Clearing the text box when a different character is speaking is not supported yet
-
Showing the name of the character speaking is not supported
-
Nameboxes for 4 characters are missing! (just waiting on our team to generate those 4 nameboxes)
-
Backlog doesn't work properly
Trying to view the text log with ADV mode enabled results in character dialogue not being recorded in the text feed.
@DogLover314 the backlog should be fixed now...but i'm not 100% confident since I haven't messed with the backlog code before. Let me know if you see any problems.
you'll need to re-download the script file to get the fix.
Maybe i didn't catch it in the list above, but it's normal that the sentences arent well justified? Like i encounter a lot of text that goes like this "hey.i'm good". With no capitalized letter after the full stop and no space between the 2 letters
@DoKu39 can you post some examples I can look up in the script? There shouldn't be any of those, as if there were, they would also be present in the non-adv mode version of the script (the version we've been using previously for a long time). So...it's probably a bug, or maybe the error was masked due to how the newline breaks occurred in the old script.
Also could you include how long ago you downloaded the adv mode script?